-
- Notifications
You must be signed in to change notification settings - Fork 52
termonad colors should be AlphaColour #112
Copy link
Copy link
Closed
Labels
beginner-friendlyGood for newcomersGood for newcomersenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Metadata
Metadata
Assignees
Labels
beginner-friendlyGood for newcomersGood for newcomersenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Termonad is using the
colourlibrary to define things like cursor colors, terminal background colors, etc.In particular, Termonad is using the
Colourtype.These
Colourtypes are converted to anRGBAfromgi-gdkin the following function:termonad/src/Termonad/Config/Colour.hs
Lines 464 to 472 in 3776e63
However, the
Colourtype doesn't actually have an associated alpha value, so we must use1.It would be more correct to use the
AlphaColourthroughout the Termonad codebase instead ofColour.This would be a relatively simple change. You'd basically just have to change all the uses of
ColourtoAlphaColourin https://github.com/cdepillabout/termonad/blob/3776e6392dd0a613f6b9e3ea85b85fe97815f685/src/Termonad/Config/Colour.hs, and then fix all the type errors.