Open
Conversation
Contributor Author
| @codex review |
| To use Codex here, create a Codex account and connect to github. |
mux-bot bot force-pushed the auto-cleanup branch from a71c5b7 to 5951a20 Compare compareSets was exported from useStableReference.ts but never called anywhere in the codebase — not in production code, not in tests. Its sibling comparators (compareMaps, compareRecords, compareArrays) are all actively used and tested; compareSets was speculatively added but never wired up.
The asyncEventIterator async generator function was exported but never imported anywhere in the codebase. Only its sibling createAsyncEventQueue is actively used (by router.ts and withQueueHeartbeat.test.ts). Remove the dead function to reduce surface area.
Four files (router.ts, workspaceService.ts, task_apply_git_patch.ts, AgentBrowserSessionDiscoveryService.ts) each defined an identical isPathInsideDir function. Extract it into src/node/utils/pathUtils.ts and replace the copies with imports.
mux-bot bot force-pushed the auto-cleanup branch from 5951a20 to 885532c Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periodic low-risk, behavior-preserving cleanups to the codebase.
Current change
Deduplicate
isPathInsideDirinto sharedpathUtils.Four files (
router.ts,workspaceService.ts,task_apply_git_patch.ts,AgentBrowserSessionDiscoveryService.ts) each defined an identicalisPathInsideDir(dirPath, filePath)function that checks whether a file pathis equal to or nested inside a directory. Extracted the function into
src/node/utils/pathUtils.tsand replaced the four copies with imports.Validation
make typecheck— passmake lint— passmake fmt-check— pass (shfmt missing in CI env, pre-existing)Auto-cleanup checkpoint: c5bf52b