Improve test coverage for tools, float, binary, geo and todo - issues…#1291
Open
shiva-kumar04 wants to merge 1 commit intocollective:mainfrom
Open
Improve test coverage for tools, float, binary, geo and todo - issues…#1291shiva-kumar04 wants to merge 1 commit intocollective:mainfrom
shiva-kumar04 wants to merge 1 commit intocollective:mainfrom
Conversation
Member
| Thanks, I added a few comments. |
niccokunzmann requested changes Mar 21, 2026
| from datetime import datetime | ||
| import pytz | ||
| | ||
| def test_normalize_pytz(): |
Member
There was a problem hiding this comment.
Suggested change
| def test_normalize_pytz(): | |
| def test_normalize_pytz(pytz_only): | |
| import pytz |
Hi, icalendar also works without pytz. This could be a solution..
| date(2024, 1, 1), | ||
| ], | ||
| ) | ||
| @pytest.mark.parametrize("Component", [Todo]) |
Member
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize("Component", [Todo]) | |
| @pytest.mark.parametrize("Component", [Todo, Event]) |
Nice! Does this also work with Event?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 698
Closes issue
Description
Improves test coverage by adding tests for previously uncovered branches. Improves coverage from 96% to 98%
Focus areas:
Checklist
CHANGES.rst.Additional information
beforeCoverage.html
afterCoverage.html