Skip to content

Honda: Accord 2023-2025 (canfd)#2610

Merged
jyoung8607 merged 69 commits intocommaai:masterfrom
mvl-boston:canfd-accord
Aug 6, 2025
Merged

Honda: Accord 2023-2025 (canfd)#2610
jyoung8607 merged 69 commits intocommaai:masterfrom
mvl-boston:canfd-accord

Conversation

@mvl-boston
Copy link
Contributor

@mvl-boston mvl-boston commented Aug 1, 2025

PR to support 2023-2025 Honda Accord

  • Based on pr 2120 from vanillagorillaa, with additional 2025 fingerprints, gas pedal calibration, and rebaselined to current opendbc
  • include safety changes from from shane and vanillagorillaa in pr 2129
  • Supports OP steering/lateral control at all speeds
  • Limited torque as typical for Honda models
  • Uses stock Acura long control, works at all speeds, includes stop/go support
  • OP long control is in separate Honda: CANFD long control #2569
  • changes consistent with canfd CRV Honda: CRV 2023-2025 (canfd) #2475
@github-actions github-actions bot added car related to opendbc/car/ honda car safety vehicle-specific safety code labels Aug 1, 2025
@jyoung8607
Copy link
Collaborator

  • Investigate lack of VIN or any firmware from OBD via comma power

Having an odd issue wherein a manual query_fw_versions is able to see the usual stuff at the usual addresses responding to 0xF181 queries, but fingerprinting at startup only picks up the radar and camera. Not sure what's going on here, will have to continue debugging tomorrow. I extended the car out to Thursday noon.

f39cf149898833ff/00000040--b40a6ac230

@mvl-boston
Copy link
Contributor Author

  • Investigate lack of VIN or any firmware from OBD via comma power

Having an odd issue wherein a manual query_fw_versions is able to see the usual stuff at the usual addresses responding to 0xF181 queries, but fingerprinting at startup only picks up the radar and camera. Not sure what's going on here, will have to continue debugging tomorrow. I extended the car out to Thursday noon.

f39cf149898833ff/00000040--b40a6ac230

I have seen over the past few months that there are waves where lots of fingerprints come back (even without comma power) for a month, and then a few fingerprints come back in a different month.

I'll look through my logs and find a breakpoint, so that you have a range of diffs to inspect. My presumption is that it is something lower level, and I didn't have time to investigate.

@github-actions github-actions bot removed the car safety vehicle-specific safety code label Aug 6, 2025
@jyoung8607
Copy link
Collaborator

Moved the FW/VIN query issue to #2632, don't love it but it's not a blocker.

There's a question around UI/HUD stuff I'll follow up on later, everything else LGTM.

@jyoung8607 jyoung8607 merged commit 065fa02 into commaai:master Aug 6, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Honda: The Power of Dreams Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car related to opendbc/car/ honda

3 participants