Skip to content

Update README.md#526

Merged
jgm merged 1 commit intocommonmark:masterfrom
Pomax:patch-1
Jan 20, 2024
Merged

Update README.md#526
jgm merged 1 commit intocommonmark:masterfrom
Pomax:patch-1

Conversation

@Pomax
Copy link
Contributor

@Pomax Pomax commented Jan 20, 2024

Fixes #525
@Pomax
Copy link
Contributor Author

Pomax commented Jan 20, 2024 •
edited
Loading

Note that this PR does not delete nmake.bat, but PowerShell can't run .bat files, and does not appear to need it in order to successfully run an nmake compilation, so it might make sense to remove that.
@jgm jgm merged commit 5caa6d5 into commonmark:master Jan 20, 2024
@jgm
Copy link
Member

jgm commented Jan 20, 2024

Thanks!
@Pomax Pomax deleted the patch-1 branch January 20, 2024 19:39
@Pomax
Copy link
Contributor Author

Pomax commented Jan 20, 2024

@jgm would you like me to make a PR that removes the nmake.bat as well? (with a separate issue filed of course so the PR can be linked to that)
@jgm
Copy link
Member

jgm commented Jan 21, 2024

I really don't know enough about Windows building to judge. I didn't put it there, and I'm not sure what purpose it serves!
@Pomax
Copy link
Contributor Author

Pomax commented Jan 21, 2024

As a "I have to use every OS on the daily" person: fair enough! In that case I'll file a PR to remove it, since it doesn't actually help make the compile work =)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Pomax @jgm