Support default parameters for AdminClient#createTopic #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
librdkafka supports creating topics with default partitions and replication factor, expose this feature to python client.
edenhill reviewed Aug 10, 2021
| config=["fails", "because not a dict"])]) | ||
| | ||
| fs = a.create_topics([NewTopic("mytopicDefault")]) | ||
| |
Contributor
There was a problem hiding this comment.
Also add a integration test to integration_test.py to verify that the topic is indeed created.
edenhill suggested changes Aug 10, 2021
Contributor
edenhill left a comment
edenhill left a comment There was a problem hiding this comment.
Good stuff, but also needs an integration test
|
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
librdkafka supports creating topics with default
partitions and replication factor, expose this
feature to python client.