Skip to content

Conversation

@chrisnovakovic
Copy link

@chrisnovakovic chrisnovakovic commented Sep 2, 2021

PyEval_InitThreads() is redundant as of Python 3.7, is a no-op (and is deprecated) as of Python 3.9, and will be removed in Python 3.11 - only call it when using Python 3.6 or below.

@ghost
Copy link

ghost commented Sep 2, 2021

It looks like @chrisnovakovic hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@chrisnovakovic
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Sep 2, 2021

@confluentinc It looks like @chrisnovakovic just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@chrisnovakovic chrisnovakovic force-pushed the PyEval_InitThreads-guard branch from ba5efcb to 446cf38 Compare September 2, 2021 12:30
@chrisnovakovic chrisnovakovic changed the title Don't call PyEval_InitThreads() when using Python >= 3.9 Don't call PyEval_InitThreads() when using Python >= 3.7 Sep 2, 2021
@edenhill
Copy link
Contributor

Can you force-push to this PR again to trigger CI jobs?

@chrisnovakovic
Copy link
Author

Sure thing. Sorry for the delay!

@chrisnovakovic chrisnovakovic force-pushed the PyEval_InitThreads-guard branch from 446cf38 to cbc66fc Compare September 20, 2021 22:03
`PyEval_InitThreads()` is redundant as of Python 3.7, is a no-op (and is deprecated, its use triggering a compiler warning) as of Python 3.9, and will be removed in Python 3.11 - only call it when using Python 3.6 or below.
@chrisnovakovic chrisnovakovic force-pushed the PyEval_InitThreads-guard branch from cbc66fc to 1b0c5c7 Compare January 27, 2023 21:46
@chrisnovakovic chrisnovakovic requested a review from a team as a code owner January 27, 2023 21:46
@CLAassistant
Copy link

CLAassistant commented Jan 27, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chrisnovakovic
Copy link
Author

Rebased on master.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ chrisnovakovic
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants