Add support for mount manager #4568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
See PR containerd/containerd#7839 and commit 34d587818596 ("Use mount.Target to specify subdirectory of rootfs mount") for more details. Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
So that $ nerdctl run --snapshotter=erofs -it --rm docker.1ms.run/library/nginx:latest /bin/sh can work now instead of erroring out as: ``` FATA[0000] failed to mount {Type:format/mkdir/overlay Source:overlay Target: Options:[lowerdir={{ overlay 0 6 }}]} on "/tmp/initialC2844197147": mount source: "overlay", target: "/tmp/initialC2844197147", fstype: format/mkdir/overlay, flags: 0, data: "lowerdir={{ overlay 0 6 }}", err: no such device ``` Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> 
Member Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
generateMountOpts() needs to be adapted since it duplicates some client code.
tested with erofs snapshotter and runC:
