Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 19, 2025

This simple fix cleans up references to data schema compilers instances within dispose() method during cache eviction. This slightly improves memory performance by allowing GC to clean up unused memory earlier.

While it won't be noticed in most cases, these changes might be useful for highload scenarios with huge data models.

Here are some insights. Pay attention to the Total Heap Allocated curve.

BEFORE:
Screenshot 2025-11-19 в 11 26 20

AFTER:
Screenshot 2025-11-19 в 11 26 26

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 19, 2025
@KSDaemon KSDaemon marked this pull request as ready for review November 19, 2025 09:33
@KSDaemon KSDaemon requested a review from a team as a code owner November 19, 2025 09:33
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.67%. Comparing base (87de073) to head (0b93c33).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ackages/cubejs-backend-shared/src/disposedProxy.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #10153 +/- ## ========================================== + Coverage 54.63% 54.67% +0.04%  ========================================== Files 213 214 +1 Lines 16972 16985 +13 Branches 3467 3467 ========================================== + Hits 9272 9286 +14  + Misses 7202 7201 -1  Partials 498 498 
Flag Coverage Δ
cube-backend 54.67% <92.30%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@KSDaemon KSDaemon requested a review from ovr November 21, 2025 14:16
@KSDaemon KSDaemon force-pushed the perf/comp-api-dispose branch from caf275f to 0b93c33 Compare November 24, 2025 09:51
@KSDaemon KSDaemon merged commit 005a46d into master Nov 24, 2025
72 of 73 checks passed
@KSDaemon KSDaemon deleted the perf/comp-api-dispose branch November 24, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

3 participants