chore(stackflow/core): Type inference friendly divideBy#557
Merged
tonyfromundefined merged 5 commits intodaangn:mainfrom Jan 20, 2025
Merged
chore(stackflow/core): Type inference friendly divideBy#557tonyfromundefined merged 5 commits intodaangn:mainfrom
divideBy#557tonyfromundefined merged 5 commits intodaangn:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 2035a02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| Open in Stackblitz • @stackflow/demo commit: |
tonyfromundefined approved these changes Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current type definition of
divideByhas loose typing that makes programmer to use unnecessary assertions or additional checks. I've changed the type so that we can remove uncomfortable assertions.Checkpoints
T. (Excludeis not an option)divideBy's being parameterized by two unrelated types was considered but eventually excluded since it does not work well with the type checker's design. (Due to subtyping, it is possible for the type checker to infer an variable as too general type)