Skip to content

feat: 1559 add pro file share distribution points #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

feat: 1559 add pro file share distribution points #837

wants to merge 20 commits into from

Conversation

@bobbyjameswilliams
Copy link
Contributor

@bobbyjameswilliams bobbyjameswilliams commented Jul 7, 2025 •
edited
Loading

Change

Migrated file share distribution points from classic to pro.

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code
thejoeker12
thejoeker12 reviewed Jul 10, 2025
View reviewed changes
sdk/jamfpro/jamfproapi_file_share_distribution_points.go
}

return &createdResponseObject, nil
// return nil, nil
Copy link
Contributor

@thejoeker12 thejoeker12 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this
Copy link
Contributor Author

@bobbyjameswilliams bobbyjameswilliams Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok boss
@thejoeker12
Copy link
Contributor

thejoeker12 commented Jul 10, 2025

Fix the title. Should be feat: blah blah.

Remove that comment or fix whatever it's supposed to do.

Approved when those things are done.
@bobbyjameswilliams bobbyjameswilliams changed the title Feat 1559 add pro file share distribution points feat: 1559 add pro file share distribution points Jul 10, 2025
@bobbyjameswilliams bobbyjameswilliams marked this pull request as draft July 10, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@bobbyjameswilliams @thejoeker12