dsl: Introduce ability to define Functions on Subdomains#2245
Merged
FabioLuporini merged 34 commits intomasterfrom Mar 4, 2025
Merged
dsl: Introduce ability to define Functions on Subdomains#2245FabioLuporini merged 34 commits intomasterfrom
FabioLuporini merged 34 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2245 +/- ## ========================================== + Coverage 87.29% 87.52% +0.22% ========================================== Files 238 238 Lines 46063 47034 +971 Branches 4080 4144 +64 ========================================== + Hits 40211 41165 +954 - Misses 5162 5176 +14 - Partials 690 693 +3 ☔ View full report in Codecov by Sentry. |
5fc54ee to a0742f0 Compare | Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
9fe8916 to 1092e78 Compare 1d37846 to d462af1 Compare Contributor
There was a problem hiding this comment.
For the amount of changes introduced, I'd prefer to see a lot more new tests.
Shouldn't all (most) of the old tests that @rhodrin wrote be here as well?
588c25e to 2cd952e Compare 2cd952e to 341ee08 Compare 4268c54 to af06ba9 Compare 08a4f5b to 3b8ec13 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Functions on SubDomains functionality.
Remaining todo (for future PRs I think):