Skip to content

Review icrc-ledger skill scope and fix known issues #106

@marc0olo

Description

@marc0olo

Context

From #96 (points 1, 11, 14) — issues found while building an AMM with skills.

Known issues

1. type: custom recipe doesn't exist (#96 point 1)

The skill suggests type: custom for deploying a test ledger. This is not a valid recipe type. The correct approach uses build.steps with type: pre-built and url:.

2. Minting account can't call icrc2_approve (#96 point 11)

Using the same principal for minting_account and initial_balances causes icrc2_approve to trap with "the minting account cannot delegate mints." Needs a pitfall.

3. No frontend ICRC-2 approval flow (#96 point 14)

Building a swap UI requires checking allowances and calling icrc2_approve from the frontend with an inline IDL factory. No skill covers this common DeFi pattern.

Broader question: skill scope

With potential canhelp and canister-calls skills on the horizon, the icrc-ledger skill's scope may need to be reconsidered. Generic canister interaction patterns (inline IDL factories, calling arbitrary canisters) could belong in those skills instead, with icrc-ledger focused on ledger-specific knowledge: deployment, init args, token standards, and pitfalls.

This should be discussed before fixing the individual issues above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions