Pywin32 upgrade #2972
Closed
Pywin32 upgrade #2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| @StefanScherer could you help with this? |
Signed-off-by: Igor Sadchenko <igor.sadchenko@gmail.com>
Signed-off-by: Igor Sadchenko <igor.sadchenko@gmail.com>
igor-sadchenko force-pushed the pywin32-upgrade branch from 33cf395 to be06f16 Compare Author
| @justincormack @thaJeztah maybe you know the answer who can help with that? |
Signed-off-by: Igor Sadchenko <igor.sadchenko@gmail.com>
milas added a commit to milas/docker-py that referenced this pull request Jul 25, 2022
Upgrade to latest pywin32, which has support for Python 3.10 and resolves a CVE (related to ACL APIs, outside the scope of what `docker-py` relies on, which is npipe support, but still gets flagged by scanners). The version constraint has also been relaxed in `setup.py` to allow newer versions of pywin32. This is similar to how we handle the other packages there, and should be safe from a compatibility perspective. Fixes docker#2902. Closes docker#2972 and closes docker#2980.
milas added a commit to milas/docker-py that referenced this pull request Jul 25, 2022
Upgrade to latest pywin32, which has support for Python 3.10 and resolves a CVE (related to ACL APIs, outside the scope of what `docker-py` relies on, which is npipe support, but still gets flagged by scanners). The version constraint has also been relaxed in `setup.py` to allow newer versions of pywin32. This is similar to how we handle the other packages there, and should be safe from a compatibility perspective. Fixes docker#2902. Closes docker#2972 and closes docker#2980. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas added a commit that referenced this pull request Jul 26, 2022
Upgrade to latest pywin32, which has support for Python 3.10 and resolves a CVE (related to ACL APIs, outside the scope of what `docker-py` relies on, which is npipe support, but still gets flagged by scanners). The version constraint has also been relaxed in `setup.py` to allow newer versions of pywin32. This is similar to how we handle the other packages there, and should be safe from a compatibility perspective. Fixes #2902. Closes #2972 and closes #2980. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Contributor
| Hi! Thanks so much for your PR and apologies for the delay in review. A fix for this has been merged and we're planning to issue a new release containing it soon. For context, changes similar to yours were done in #3004 to address some CI changes in the repo, which blocked merging of your PR as-is, and given the delay on this, we wanted to be respectful of our contributor's time and not require you to rebase + re-review. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix issue #2902
@aiordache @ulyssessouza, please, accept this PR to fix this annoying bug