Skip to content

Conversation

@akerouanton
Copy link
Member

moby/moby#46251 marks CheckDuplicate as deprecated. Any NetworkCreate request with a conflicting network name will now return an error.

@akerouanton
Copy link
Member Author

@milas PTAL 🤗

@akerouanton akerouanton force-pushed the remove-test_create_check_duplicate branch from 3d4b895 to ea48e4b Compare August 19, 2023 12:56
@thaJeztah
Copy link
Member

AttachContainerTest.test_attach_no_stream ___________________ tests/integration/api_container_test.py:1299: in test_attach_no_stream assert output == 'hello\n'.encode(encoding='ascii') E AssertionError: assert b'' == b'hello\n' E Use -v to get more diff ___________________ TestNetworks.test_create_check_duplicate ___________________ tests/integration/api_network_test.py:330: in test_create_check_duplicate self.tmp_networks.append(net_id['Id']) E TypeError: string indices must be integers 

Ha! Wondering if the last failure is an implicit type conversion; if the network ID could be parsed as a hexadecimal🤔

Let me try restarting CI

@thaJeztah
Copy link
Member

Although it failed in 2 check, so perhaps that line needs to be removed (and was only needed for the second test?)

@akerouanton akerouanton force-pushed the remove-test_create_check_duplicate branch from ea48e4b to 92c714a Compare August 19, 2023 13:57
moby/moby#46251 marks CheckDuplicate as deprecated. Any NetworkCreate request with a conflicting network name will now return an error. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
@akerouanton akerouanton force-pushed the remove-test_create_check_duplicate branch from 92c714a to 6eddc0a Compare August 19, 2023 14:00
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milas PTAL

@milas milas merged commit c38656d into docker:main Aug 21, 2023
@akerouanton akerouanton deleted the remove-test_create_check_duplicate branch August 21, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants