Add service lifetime support to DI helpers.#5880
Merged
eiriktsarpalis merged 3 commits intodotnet:mainfrom Feb 12, 2025
Merged
Conversation
eiriktsarpalis commented Feb 11, 2025
...aries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilderServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
eiriktsarpalis commented Feb 11, 2025
...aries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilderServiceCollectionExtensions.cs Show resolved Hide resolved
stephentoub reviewed Feb 11, 2025
...aries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilderServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948675&view=codecoverage-tab |
stephentoub reviewed Feb 12, 2025
...aries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilderServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
stephentoub approved these changes Feb 12, 2025
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=950106&view=codecoverage-tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
ServiceLifetimeoptional parameter to all the DI helpers, defaulting toSingleton.Fix #5875.
Microsoft Reviewers: Open in CodeFlow