Fix issue importing an SDK via Import element.#2038
Merged
AndyGerlicher merged 3 commits intodotnet:vs15.3-previewfrom May 1, 2017
Merged
Fix issue importing an SDK via Import element.#2038AndyGerlicher merged 3 commits intodotnet:vs15.3-previewfrom
AndyGerlicher merged 3 commits intodotnet:vs15.3-previewfrom
Conversation
jeffkl approved these changes May 1, 2017
cdmihai reviewed May 1, 2017
Contributor
There was a problem hiding this comment.
So explicit attributes instead of fancy string that needs to be parsed?
The XSD should probably be updated at some point, since SDKs introduced a couple of new attributes / elements.
cdmihai reviewed May 1, 2017
Contributor
There was a problem hiding this comment.
Add a new test to construction editing tests to assert null values, non-null values, etc. For example, what happens if you add an SDK import element inside an import group group together with non SDK import elements.
Member
There was a problem hiding this comment.
Not sure I understand the motivation for this. Can you elaborate?
rainersigwald approved these changes May 1, 2017
cdmihai approved these changes May 1, 2017
* This feature was regressed in dotnet#2002 * Update unit tests to verify functionality * Update ProjectParser to parse SDK name/version values and construct an SdkReference object to be used by the evaluator. Closes dotnet#2034
AndyGerlicher force-pushed the importsdkfix branch from c9b5a25 to c45f772 Compare 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2034