Open
Conversation
Contributor
| I think we should have separate objects and accessors for the rotation rates. We don't conflate position and its first derivation velocity, so I can't see why we'd want to do it for attitude. So basically an AttitudeRate object. Does that make sense? Ah, the argument "that's how MAVLink does it" isn't a great one, either. MAVLink (and its implementations) gets lots of stuff wrong, and dronekit-python is supposed to kinda fix these things :-) |
Contributor
| FWIW Yes to an |
Contributor
| @cheintz any progress on this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed to be a good place for them, as they come in the Attitude MAVlink packet.
Resubmitting after rebasing on dronekit:master