Update Windows Setup.iss for silent installs#298
Open
Jprosser91 wants to merge 1 commit intodtarb:Developfrom
Open
Update Windows Setup.iss for silent installs#298Jprosser91 wants to merge 1 commit intodtarb:Developfrom
Jprosser91 wants to merge 1 commit intodtarb:Developfrom
Conversation
When Installing TauDEM silently (TauDEM540_setup_x64.exe /VERYSILENT /SUPPRESSMSGBOXES) on windows, the message boxes to install GDAL Python Bindings and the reboot message will interrupt silent installs. I've replaced all instances of Msgbox() with SuppressibleMsgBox() and configured it to accept by default. The message boxes will continue to pop up during a normal install but no interruptions will happen during a silent install as long as /VERYSILENT /SUPPRESSMSGBOXES is added. https://jrsoftware.org/ishelp/topic_isxfunc_suppressiblemsgbox.htm I've also added runhidden on line 146 to hide the python installation. This won't interrupt the install if it is visible, so it isn't necessary but prevents it from showing through all install types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Installing TauDEM silently (TauDEM540_setup_x64.exe /VERYSILENT /SUPPRESSMSGBOXES) on windows, the message boxes to install GDAL Python Bindings and the reboot message will interrupt silent installs.
I've replaced all instances of Msgbox() with SuppressibleMsgBox() and configured it to accept by default. The message boxes will continue to pop up during a normal install but no interruptions will happen during a silent install as long as /VERYSILENT /SUPPRESSMSGBOXES is added.
https://jrsoftware.org/ishelp/topic_isxfunc_suppressiblemsgbox.htm
I've also added runhidden on line 146 to hide the python installation. This won't interrupt the install if it is visible, so it isn't necessary but prevents it from showing through all install types.