feat: add sequelize example #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @iyuq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @dead-horse to be potential reviewers. |
atian25 reviewed Jun 12, 2017
sequelize-example/README.md Outdated
| see [egg docs][egg] for more detail. | ||
| | ||
| ### Unittest | ||
| ```shell |
sequelize-example/README.md Outdated
| | ||
| ### Unittest | ||
| ```shell | ||
| $ createdb example-unittest --owner postgres |
Member
There was a problem hiding this comment.
add to test/.setup.js ? like https://github.com/eggjs/egg-mysql/blob/master/test/.setup.js
| @@ -0,0 +1,23 @@ | |||
| 'use strict'; | |||
| | |||
| module.exports = () => { | |||
Contributor Author
There was a problem hiding this comment.
现在egg是不是默认就使用了onerror的。
Member
| 可以合了吗 |
jtyjty99999 approved these changes Jun 13, 2017
atian25 approved these changes Jun 13, 2017
atian25 reviewed Jun 13, 2017
sequelize-example/README.zh-CN.md Outdated
| [![build][build]][build-url] | ||
| [![coverage][cover]][cover-url] | ||
| | ||
| 使用egg-sequelize插件的egg示例项目。 |
Member
There was a problem hiding this comment.
中英文混排，前后加空格 使用 egg-sequelize 插件的 egg 示例项目。
sequelize-example/README.md Outdated
| [![build][build]][build-url] | ||
| [![coverage][cover]][cover-url] | ||
| | ||
| The egg example project that uses egg-sequelize plugin. |
Member
There was a problem hiding this comment.
加下 egg-sequelize 的链接， [egg-sequelize](http://....)
| return class UserController extends app.Controller { | ||
| * posts() { | ||
| this.ctx.body = yield this.service.post.list(this.ctx.query); | ||
| * posts(ctx) { |
Member
There was a problem hiding this comment.
class 模式下，还是用 this.ctx 好点。
* posts() { const ctx = this.ctx; }
Contributor Author
| @atian25 改完了，再看看 |
atian25 approved these changes Jun 13, 2017
sequelize-example/README.md Outdated
| # sequelize-example | ||
| | ||
| The egg example project that uses egg-sequelize plugin. | ||
| The [egg][egg] example project that uses [egg-sequelize][egg-sequelize] plugin. |
Member
| +1 , ci 过就合并 |
Member
| ref: eggjs/egg#1026 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@atian25 @jtyjty99999 sequelize-example已加。