Temporarily store signals in disk 3/3 #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nto AppInfoService
This reverts commit 15b3694.
LikeTheSalad requested review from AlexanderWert, bmorelli25, bryce-b and felixbarny 
bmorelli25 reviewed Aug 16, 2023
bmorelli25 reviewed Aug 16, 2023
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
bryce-b reviewed Aug 17, 2023
| | ||
| public PersistenceConfiguration build() { | ||
| if (exportScheduler == null) { | ||
| exportScheduler = ExportScheduler.getDefault(60 * 60 * 1000); // Every hour by default |
There was a problem hiding this comment.
Is the default for exporting data to the collector 60 minutes? 60 seconds should be more appropriate.
Contributor Author
There was a problem hiding this comment.
I don't have a strong opinion about this, so if the iOS agent uses 60 seconds already then I'll do the same here to keep consistency!
Contributor Author
There was a problem hiding this comment.
It's updated now
…istence exportings
# Conflicts: # CHANGELOG.asciidoc
bryce-b approved these changes Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #94
Final changes to fully add support for disk persistence of signals. I've also updated the docs to include information on how to use this new feature!