Hanlde corner cases for empty or null service name #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SylvainJuge commented Mar 25, 2020
| if (commandPart.endsWith(".jar")) { | ||
| return removeVersionFromJar(removePath(removeJarExtension(commandPart))); | ||
| result = removeVersionFromJar(removePath(removeJarExtension(commandPart))); | ||
| break; |
Member Author
There was a problem hiding this comment.
using a break here allows to maximize coverage, otherwise the return null; statement was dead code
felixbarny approved these changes Mar 25, 2020
Codecov Report
@@ Coverage Diff @@ ## master #1097 +/- ## ============================================ + Coverage 58.82% 60.00% +1.18% Complexity 87 87 ============================================ Files 334 327 -7 Lines 15539 14768 -771 Branches 2209 2059 -150 ============================================ - Hits 9141 8862 -279 + Misses 5778 5308 -470 + Partials 620 598 -22 Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tests and improve heuristics to get service name from JVM system properties.
Current implementation might allow to have empty values and did not handled properly values with spaces.
Checklist
I have made corresponding changes to the documentationI have updated supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introducedAdded an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?Author's Checklist