Skip to content

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Mar 31, 2020

Fixes broken breakdown metrics reporting.

For example, when there was multiple database vendors used, only one of them was included in breakdown metrics, thus with an app with mysql and redis, at most one of them was being reported, but not both.

What does this PR do?

  • span sub-type was not included in Labels equals/hashcode
  • span sub-type was not being properly reset (for mutable labels)

Checklist

  • My code follows the style guidelines of this project
  • I have rebased my changes on top of the latest master branch
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated CHANGELOG.asciidoc
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced
  • Added an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?

Related issues

Screenshot

With an application that has two database spans sub-types: h2 and other

Before

Screenshot from 2020-03-31 16-06-44

After

Screenshot from 2020-03-31 16-07-56

as a bonus span subtype wasn't being reset properly
@SylvainJuge SylvainJuge requested a review from felixbarny March 31, 2020 14:11
@SylvainJuge SylvainJuge merged commit d44b384 into elastic:master Apr 1, 2020
@SylvainJuge SylvainJuge deleted the fix-span-subtype-metrics branch April 1, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants