Fix WebLogic NPE #1142
Merged
Fix WebLogic NPE #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eyalkoren approved these changes Apr 16, 2020
Contributor
eyalkoren left a comment
eyalkoren left a comment There was a problem hiding this comment.
It means we will have an extra space at the end of the transaction name -
. Do we care?| String servletPath, @Nullable String pathInfo, @Nullable String contentTypeHeader, boolean deactivate) { | ||
| @Nullable String servletPath, @Nullable String pathInfo, @Nullable String contentTypeHeader, boolean deactivate) { | ||
| if (servletPath == null) { | ||
| // the servlet path is specified as non-null but WebLogic does return null... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Spotted in a log, running version 1.15.0: