Skip to content

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Nov 6, 2020

What does this PR do?

Fixes #1474

Add an extra runtime property elastic.apm.disable_bootstrap_checks that allows to bypass JVM version check when it's value is set to true.

Checklist

@SylvainJuge SylvainJuge requested a review from eyalkoren November 6, 2020 14:15
@ghost
Copy link

ghost commented Nov 6, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user eyalkoren, Replayed #10]

  • Start Time: 2020-11-09T12:04:58.738+0000

  • Duration: 45 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 1617
Skipped 12
Total 1629

@codecov-io
Copy link

Codecov Report

Merging #1477 into master will increase coverage by 4.80%.
The diff coverage is 63.33%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1477 +/- ## ============================================ + Coverage 59.25% 64.05% +4.80%  - Complexity 92 3101 +3009  ============================================ Files 392 305 -87 Lines 17604 15225 -2379 Branches 2437 2107 -330 ============================================ - Hits 10431 9753 -678  + Misses 6458 4804 -1654  + Partials 715 668 -47 
Impacted Files Coverage Δ Complexity Δ
.../main/java/co/elastic/apm/agent/bci/AgentMain.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/co/elastic/apm/agent/util/JvmRuntimeInfo.java 81.81% <86.36%> (+3.38%) 25.00 <1.00> (+25.00)
...ic/apm/agent/profiler/collections/LongHashSet.java 16.66% <0.00%> (-1.59%) 12.00% <0.00%> (+12.00%) ⬇️
...t/urlconnection/UrlConnectionPropertyAccessor.java
...nt/dubbo/AlibabaResponseFutureInstrumentation.java
.../springwebmvc/ExceptionHandlerInstrumentation.java
...stic/apm/agent/kafka/BaseKafkaInstrumentation.java
...tic/apm/agent/jsf/JsfLifecycleInstrumentation.java
...ava/co/elastic/apm/opentracing/ElasticApmTags.java
...pentracing/impl/ApmSpanBuilderInstrumentation.java
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f3854...f30119f. Read the comment docs.

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
We need to document the disable_bootstrap_checks flag somehow.
See suggestion to do that when aborting at startup.

In addition, I think we can at least add it to the NOTE message we have at the supported Java version section.
This section needs to be updated to include these new JVM limitations as well.

@eyalkoren eyalkoren merged commit f4ba580 into elastic:master Nov 9, 2020
@SylvainJuge SylvainJuge deleted the fix-hpux-version-parsing branch November 9, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants