Skip to content

Fix NPE when async ES client is nested within Hibernate search #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2020
Merged

Fix NPE when async ES client is nested within Hibernate search #1531

merged 4 commits into from
Nov 25, 2020

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Nov 24, 2020 •
edited by zube bot
Loading

Closes #1528
When ES client is used within Hibernate search, the helper code produces a null span as we don't allow nested exit spans.
@ghost
Copy link

ghost commented Nov 24, 2020 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1531 updated]

  • Start Time: 2020-11-24T14:43:42.786+0000

  • Duration: 43 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 1617
Skipped 12
Total 1629

@eyalkoren eyalkoren requested a review from felixbarny November 24, 2020 14:44
@eyalkoren eyalkoren mentioned this pull request Nov 25, 2020
Closed
@eyalkoren eyalkoren merged commit 0c5f924 into elastic:master Nov 25, 2020
@eyalkoren eyalkoren deleted the fix-npe-es-async-client-instr branch November 25, 2020 04:27
@eyalkoren eyalkoren mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java

2 participants

@eyalkoren @felixbarny