Loading ConnectionMetaData from the agent class loader #1864
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The theory:
When multiple JDBC implementations on a Servlet container share a data source, they may also share JDBC connection instances. Since the connection --> metadata cache is managed as a global state across the entire JVM, and the created
ConnectionMetaDatavalues stored in it are created by the plugin, this may cause aClassCastExceptionif one JDBC driver is storing a metadata instance for a connection instance and another one is retrieving it.Normally this is not an issue because there will be a single JDBC dependency, but there may be cases where there are multiple JDBC dependencies. It still requires a special setup where
java.sql.Statementimplementations are loaded from some class loader while thejava.sql.Connectionclass is shared, so that the connection instances can be shared.This PR fixes the issue by ensuring that the
ConnectionMetaDatais always loaded only by the agent class loader.Checklist