Skip to content

Only use Connection#getCatalog if it is supported by the JDBC driver #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 19, 2021
Merged

Only use Connection#getCatalog if it is supported by the JDBC driver #2340

merged 8 commits into from
Dec 19, 2021

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Dec 14, 2021 •
edited by zube bot
Loading

What does this PR do?

Fixes #2338

Checklist

  • This is a bugfix
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Dec 14, 2021
@github-actions
Copy link

github-actions bot commented Dec 14, 2021

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.
@ghost
Copy link

ghost commented Dec 14, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-17T16:17:52.606+0000

  • Duration: 75 min 55 sec

  • Commit: 2cedff6

Test stats 🧪

Test Results
Failed 0
Passed 2639
Skipped 21
Total 2660

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
SylvainJuge
SylvainJuge requested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor things to change.
@SylvainJuge
Copy link
Member

SylvainJuge commented Dec 17, 2021

/test
@tobiasstadler @SylvainJuge
Apply suggestions from code review by @SylvainJuge
2cedff6 
Co-authored-by: SylvainJuge <syl20j@gmail.com>
@eyalkoren
Copy link
Contributor

eyalkoren commented Dec 19, 2021

run elasticsearch-ci/docs
@eyalkoren eyalkoren enabled auto-merge (squash) December 19, 2021 07:31
@eyalkoren eyalkoren merged commit 9794890 into elastic:master Dec 19, 2021
@tobiasstadler tobiasstadler deleted the fix-2338 branch December 19, 2021 08:59
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Dec 19, 2021

Thank You!
@eyalkoren
Copy link
Contributor

eyalkoren commented Dec 20, 2021

Thank YOU! 😄
@eyalkoren eyalkoren mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community triage

3 participants

@tobiasstadler @SylvainJuge @eyalkoren