Adding instrumentation warmup #2368
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tries to invoke as much as possible instrumentation-related code paths, including the instrumentation logic and the
invokedynamicruntime linkage path, on the agent-attaching thread before registering theClassFileTransformerto the JVM-globaljava.lang.instrument.Instrumentation.This ensures that most Byte Buddy and agent types related to these processes are loaded and initialized on a single thread, thus reducing the chances for deadlock.
We will start with having warmup on by default, but with a hidden config flag that enables disabling it.
Checklist