Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Mar 27, 2022

Fixes #2545 - a small bug introduced through #2418

@ghost
Copy link

ghost commented Mar 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-29T08:55:08.191+0000

  • Duration: 50 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 2840
Skipped 20
Total 2860

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably take the time to see why it wasn't properly tested.

@eyalkoren
Copy link
Contributor Author

we should probably take the time to see why it wasn't properly tested

This instrumentation should not be affected on javax-based Servlet containers, only the jakarta ones, but I think we do have such being tested, which means there is no test for this specific functionality.

@eyalkoren eyalkoren merged commit daa833e into elastic:main Mar 29, 2022
@eyalkoren eyalkoren deleted the ServletContainerInitializerServiceNameInstrumentation-fix branch March 29, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants