Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Mar 28, 2022

What does this PR do?

Closes #2527
Allows square brackets within the JMX config option value, e.g.

object_name[amx:pp=/mon/server-mon[server],type=...] attribute[...] 

@felixbarny is there a reason not to allow that?

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • I have made corresponding changes to the documentation
@ghost
Copy link

ghost commented Mar 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-04T14:39:21.243+0000

  • Duration: 45 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 2842
Skipped 20
Total 2862

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@eyalkoren eyalkoren merged commit e2ef245 into elastic:main Apr 5, 2022
@eyalkoren eyalkoren deleted the jmx-parse-fix branch April 5, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants