Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented May 16, 2022

What does this PR do?

Adds APIs to make spans non-discardable

Checklist

  • Added to public API
  • Added public API tests
  • Added to public API docs
  • Added to annotations API
  • Added annotations API tests
  • Added to annotations API docs
  • Added to OTel bridge through a custom attribute
  • Added OTel tests
  • Added to OTel docs
  • Added to CHANGELOG
@ghost
Copy link

ghost commented May 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-24T09:55:57.248+0000

  • Duration: 48 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 2904
Skipped 22
Total 2926

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@eyalkoren eyalkoren requested a review from SylvainJuge May 17, 2022 08:30
@eyalkoren
Copy link
Contributor Author

@SylvainJuge please only take a look at the latest commits adding support for this in the annotations API and not reverting the exposure of the custom attributes as we discussed

@eyalkoren eyalkoren enabled auto-merge (squash) May 24, 2022 09:55
@eyalkoren eyalkoren merged commit 9cd79b2 into elastic:main May 24, 2022
@eyalkoren eyalkoren deleted the non-discardable-api branch May 24, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants