Fix flaky webflux transaction name #2695
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes flaky transaction name when Webflux is used with Servlet transaction.
The underlying issue is that the transaction name is set in Webflux thread just after the transaction ends, which makes the Servlet instrumentation end the transaction and sometimes use a default name.
In order to fix this, I've just moved the part that sets the transaction name just before the transaction is being ended, which allows to make sure that the Servlet transaction won't be ended until the nested
onErrororonCompletemethod is called.When the transaction is created and ended by Webflux without servlets, this does not change anything.
Checklist