Skip to content

Debug/fix reactor instrumentation side-effects #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

Debug/fix reactor instrumentation side-effects #2708

merged 2 commits into from
Jul 11, 2022

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jul 11, 2022 •
edited
Loading

What does this PR do?

Fixes #2701

Checklist
@SylvainJuge SylvainJuge mentioned this pull request Jul 11, 2022
Closed
@ghost
Copy link

ghost commented Jul 11, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-11T13:17:34.532+0000

  • Duration: 49 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 3054
Skipped 36
Total 3090

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@SylvainJuge SylvainJuge marked this pull request as ready for review July 11, 2022 13:17
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

/test
jackshirazi
jackshirazi reviewed Jul 11, 2022
View reviewed changes
...-plugins/apm-reactor-plugin/src/main/java/co/elastic/apm/agent/reactor/TracedSubscriber.java
private static final WeakMap<Class<?>, Boolean> toStringSupported = WeakConcurrent.buildMap();

private static String safeToString(CoreSubscriber<?> subscriber) {
Class<?> type = subscriber.getClass();
Copy link
Contributor

@jackshirazi jackshirazi Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we guaranteed subscriber is not null at this point?
Copy link
Member Author

@SylvainJuge SylvainJuge Jul 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the lift (or liftPublisher) method goal is to replace/wrap one subscriber with another, thus having null here would not make sense, and we would had lots of NPEs reported if it would be the case when we call subscriber.currentContext().
@SylvainJuge SylvainJuge enabled auto-merge (squash) July 11, 2022 14:03
@SylvainJuge SylvainJuge merged commit 2aacd8d into elastic:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java

2 participants

@SylvainJuge @jackshirazi