Make api_key and secret_token dynamic #2889
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #2854.
Allows the
api_keyandsecret_tokenconfigurations to be dynamic.When the configuration option changes, all new connections to the APM server will be made with the changed key.
Existing connections will not be terminated on change, but they are already authorized anyway.
I did some manual testing by providing the
secret_tokenviaelasticapm.propertiesand changing it at runtime.Checklist
Added an API method or config option? Document in which version this will be introduced