Skip to content

Conversation

@markush81
Copy link
Contributor

@markush81 markush81 commented Feb 18, 2023

What does this PR do?

Fixes #2976 same way OTel has implemented its instrumentation of HttpURLConnection

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Feb 18, 2023
@github-actions
Copy link

👋 @markush81 Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@markush81 markush81 force-pushed the apm-agent-java/issues/2976 branch from 1166af1 to 8b93035 Compare February 18, 2023 09:01
@markush81 markush81 force-pushed the apm-agent-java/issues/2976 branch from 8b93035 to 9e80b23 Compare February 18, 2023 09:02
@ghost
Copy link

ghost commented Feb 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T11:03:40.459+0000

  • Duration: 57 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 3533
Skipped 121
Total 3654

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@markush81 markush81 changed the title Github Issue 2976 - fix insipired by OTel agent implementation Issue 2976 - fix insipired by OTel agent implementation Feb 18, 2023
@markush81 markush81 changed the title Issue 2976 - fix insipired by OTel agent implementation HttpURLConnection (#2976) - fix insipired by OTel agent implementation Feb 18, 2023
@eyalkoren
Copy link
Contributor

@markush81 thanks for taking a shot on this! 🙏
Please see my last comment on the original issue. It explains how we think it would be best to approach this.
If you want to implement this yourself, we will be happy to assist and review. Otherwise, if you don't mind and agree that this approach is preferable, we can implement that.
Please let us know.

… own to cover the fact that this method handles certain exceptions on its own
* main: make the Agent.activationMethod field immutable (elastic#3032) Add Activation method for telemetry on how the agent was started (elastic#2926) Unnest exceptions before filtering (elastic#3025) Use composite action for updatecli workflow (elastic#3023) # Conflicts: #	CHANGELOG.asciidoc
@markush81 markush81 changed the title HttpURLConnection (#2976) - fix insipired by OTel agent implementation HttpURLConnection (#2976) - fix getResponseCode handled exceptions Feb 23, 2023
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!
Please add the requested test to fully verify our intentions are addressed and maintained.

@eyalkoren
Copy link
Contributor

/test

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙏

@eyalkoren
Copy link
Contributor

/test

@markush81
Copy link
Contributor Author

run elasticsearch-ci/docs

1 similar comment
@eyalkoren
Copy link
Contributor

run elasticsearch-ci/docs

Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@eyalkoren eyalkoren merged commit 3416381 into elastic:main Feb 23, 2023
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community triage

3 participants