- Notifications
You must be signed in to change notification settings - Fork 327
HttpURLConnection (#2976) - fix getResponseCode handled exceptions #3024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 👋 @markush81 Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
1166af1 to 8b93035 Compare 8b93035 to 9e80b23 Compare | @markush81 thanks for taking a shot on this! 🙏 |
… own to cover the fact that this method handles certain exceptions on its own
* main: make the Agent.activationMethod field immutable (elastic#3032) Add Activation method for telemetry on how the agent was started (elastic#2926) Unnest exceptions before filtering (elastic#3025) Use composite action for updatecli workflow (elastic#3023) # Conflicts: # CHANGELOG.asciidoc
eyalkoren left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Please add the requested test to fully verify our intentions are addressed and maintained.
...n/src/test/java/co/elastic/apm/agent/urlconnection/HttpUrlConnectionInstrumentationTest.java Show resolved Hide resolved
...n/src/test/java/co/elastic/apm/agent/urlconnection/HttpUrlConnectionInstrumentationTest.java Show resolved Hide resolved
| /test |
eyalkoren left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🙏
| /test |
| run elasticsearch-ci/docs |
1 similar comment
| run elasticsearch-ci/docs |
jackshirazi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
What does this PR do?
Fixes #2976 same way OTel has implemented its instrumentation of
HttpURLConnectionChecklist