Fix external plugin OpenTelemetry instrumentation #3154
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3145 .
The GlobalOpenTelemetry instrumentation was broken for external plugins due to a sideeffect of hiding the internal Otel-API shipped within the agent classloader from the
IndyPluginClassloader:IndyPluginClassloaders contain a copy of all classes of the external plugin jar. This means alsoGlobalOpenTelemetryis copied to theIndyPluginClassloader.GlobalOpenTelemetryhas a classloader check ensuring that the target classloader can actually load the Otel-API. This is done by trying to load theio.opentelemetry.context.propagation.TextMapSetter.classresourceIndyPluginClassloaderscannot locate the resources for their corresponding classes and therefore delegate this search to their parent classloader.GlobalOpenTelemetryis not instrumentable.Checklist