Fix invalid currentTransaction() logic #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JonasKunz added the ci:jdk-compatibility 
SylvainJuge approved these changes Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While enhancing the kafka tests I noticed a strange behaviour: The kafka instrumentation would stop correctly ending transaction if the initial context is baggage without a span / transaction.
This was due to the implementation of
ActiveStak.currentTransaction()which relies on the transaction being the first element on the stack.This is not always true in case of baggage, but also was wrong prior to the baggage addition in cases where a nested transaction shadows the original one.
The tests (except for the one fixed in this pr) remain green, therefor I assume there should be no bad side effects.
Checklist