Skip to content

Conversation

@jackshirazi
Copy link
Contributor

What does this PR do?

Empty histograms are produced by the micrometer plugin, but these are not valid for the APM server so need to be discarded. Note for the reviewer, the Otel metrics serialization doesn't need changing, the Otel metrics doesn't produce any histogram if the histogram is empty

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants