Skip to content

Add ability to get tracing headers from API #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add ability to get tracing headers from API #394

wants to merge 1 commit into from

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented Dec 19, 2018 •
edited
Loading

closes #334
@codecov-io
Copy link

codecov-io commented Dec 19, 2018 •
edited
Loading

Codecov Report

Merging #394 into master will decrease coverage by 0.3%.
The diff coverage is 40%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #394 +/- ## ============================================ - Coverage 71.46% 71.15% -0.31%  + Complexity 1199 1194 -5  ============================================ Files 133 133 Lines 4612 4622 +10 Branches 471 472 +1 ============================================ - Hits 3296 3289 -7  - Misses 1103 1118 +15  - Partials 213 215 +2
Impacted Files Coverage Δ Complexity Δ
.../agent/plugin/api/AbstractSpanInstrumentation.java 50.87% <40%> (-2.32%) 3 <0> (ø)
.../elastic/apm/agent/bci/bytebuddy/MatcherTimer.java 62.5% <0%> (-31.25%) 4% <0%> (-3%)
...c/apm/agent/bci/MatcherTimerLifecycleListener.java 75% <0%> (-18.75%) 4% <0%> (-1%)
...java/co/elastic/apm/agent/bci/ElasticApmAgent.java 69.92% <0%> (-2.26%) 18% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934ae1b...ba435d6. Read the comment docs.
felixbarny
felixbarny commented Dec 19, 2018
View reviewed changes
apm-agent-api/src/main/java/co/elastic/apm/api/Span.java
*/
boolean isSampled();

void addTraceHeaders(@Nullable Map<? super String, ? super String> headers);
Copy link
Member Author

@felixbarny felixbarny Dec 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Javadoc
@felixbarny felixbarny requested a review from eyalkoren December 19, 2018 13:33
@felixbarny felixbarny mentioned this pull request Dec 19, 2018
Closed
eyalkoren
eyalkoren approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Let's follow up with the receiver side.
@felixbarny felixbarny mentioned this pull request Dec 21, 2018
Merged
@felixbarny felixbarny self-assigned this Dec 21, 2018
@felixbarny
Copy link
Member Author

felixbarny commented Jan 7, 2019

Superseded by #396
@felixbarny felixbarny closed this Jan 7, 2019
@felixbarny felixbarny deleted the trace-header-api branch January 7, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@felixbarny @codecov-io @eyalkoren @alvarolobato