avoid calling missing method on kafka-clients 4.x #4136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
JonasKunz previously approved these changes Jul 3, 2025
Contributor
JonasKunz left a comment
JonasKunz left a comment There was a problem hiding this comment.
LGTM, nicely solved! Would be great if you could find a way to add a version test with 4.0
Member Author
| I tried to add proper testing with 4.0.0 client (which has just been released a few weeks ago), but this would be quite a challenging task, there is a hint about this here, doing so would likely require to create extra test modules and rework a bit existing tests, so definitely not a trivial effort. |
JonasKunz approved these changes Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4135
Checklist