Use JSP path name as transaction name #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eyalkoren reviewed Jul 28, 2019
| | ||
| public T appendToName(String s, int priority) { | ||
| if (priority >= namePriority) { | ||
| name.append(s); |
Contributor
There was a problem hiding this comment.
Suggested change
| name.append(s); | |
| name.append(s); | |
| this.namePriority = priority; |
Add a test that fails without that
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.Mockito.mock; | ||
| | ||
| @DisabledOnOs(OS.MAC) |
| transaction = tracer.startTransaction(TraceContext.asRoot(), null, clazz.getClassLoader()) | ||
| .withName(transactionName.isEmpty() ? signature : transactionName) | ||
| .withName(transactionName, AbstractSpan.PRIO_USER_SUPPLIED) | ||
| .withName(signature, AbstractSpan.PRIO_METHOD_SIGNATURE) |
Contributor
There was a problem hiding this comment.
I think if/else reads better..
Contributor
| I merged a PR disabling the annoying JMS test that failed, so you can merge with master.. |
2 tasks
felixbarny force-pushed the jsp-transaction-name branch from eef1363 to 2845973 Compare 
rather than the name of the generated servlet closes elastic#429
felixbarny force-pushed the jsp-transaction-name branch from 2845973 to d53011a Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
rather than the name of the generated servlet
closes #429
depends on #748