Skip to content

Conversation

@videnkz
Copy link
Contributor

@videnkz videnkz commented Jan 14, 2020

Checklist

closes #982

@videnkz videnkz changed the title Issue 982 remove context message topic field Issue 982 removed topicName field from Message Jan 14, 2020
@videnkz videnkz requested a review from eyalkoren January 14, 2020 19:03
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #993 into master will increase coverage by 4.79%.
The diff coverage is 66.66%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #993 +/- ## ============================================ + Coverage 63.63% 68.43% +4.79%  - Complexity 85 2153 +2068  ============================================ Files 255 219 -36 Lines 10482 9259 -1223 Branches 1391 1191 -200 ============================================ - Hits 6670 6336 -334  + Misses 3402 2537 -865  + Partials 410 386 -24
Impacted Files Coverage Δ Complexity Δ
...ic/apm/agent/jms/JmsInstrumentationHelperImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/co/elastic/apm/agent/impl/context/Message.java 96.42% <0%> (-0.55%) 14 <2> (+14)
.../apm/agent/report/serialize/DslJsonSerializer.java 90.57% <100%> (-0.06%) 180 <0> (+180)
...ntracing/impl/ElasticApmTracerInstrumentation.java
...h/src/main/java/co/elastic/apm/attach/JvmInfo.java
...agent/process/CommonsExecAsyncInstrumentation.java
.../main/java/co/elastic/apm/opentracing/ApmSpan.java
...a/co/elastic/apm/opentracing/ElasticApmTracer.java
...Mule4OverrideClassLoaderLookupInstrumentation.java
...tracing/impl/OpenTracingBridgeInstrumentation.java
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c23329...79792cf. Read the comment docs.

@eyalkoren
Copy link
Contributor

@kananindzya that's awesome, thanks!!
Just please update CHANGELOG.asciidoc

@videnkz
Copy link
Contributor Author

videnkz commented Jan 15, 2020

@kananindzya that's awesome, thanks!!
Just please update CHANGELOG.asciidoc

updated

@felixbarny felixbarny merged commit 516f8fb into elastic:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants