Skip to content

Conversation

@beniwohli
Copy link
Contributor

What does this pull request do?

Removes all usage of Python 2-specific usage of the compat module.

First commit is only the elasticapm module, second commit is the test suite.

Related issues

closes #ISSUE

@ghost
Copy link

ghost commented Feb 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-16T08:24:03.883+0000

  • Duration: 26 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 4818
Skipped 2918
Total 7736

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@beniwohli
Copy link
Contributor Author

/test full

@beniwohli
Copy link
Contributor Author

/test full

@beniwohli beniwohli requested a review from basepi February 15, 2022 14:04
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

@beniwohli beniwohli merged commit 87ed608 into elastic:main Feb 16, 2022
@beniwohli beniwohli deleted the remove-py2-compat branch February 16, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants