Skip to content

Disable checks when elastic_apm is disabled #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2022
Merged

Disable checks when elastic_apm is disabled #1632

merged 3 commits into from
Sep 15, 2022

Conversation

@francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Sep 14, 2022 •
edited
Loading

Avoids warning about an incorrect SERVER_URL when the tool is not in use.
@francoisfreitag
Disable checks when elastic_apm is disabled
937b26f 
Avoids warning about an incorrect SERVER_URL when the tool is not in use.
@cla-checker-service
Copy link

cla-checker-service bot commented Sep 14, 2022 •
edited
Loading

💚 CLA has been signed
@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Sep 14, 2022
@ghost
Copy link

ghost commented Sep 14, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-15T13:58:05.862+0000

  • Duration: 31 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 4986
Skipped 3338
Total 8324

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
basepi
basepi approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for adding a test!
@basepi
Copy link
Contributor

basepi commented Sep 14, 2022

/test
@ghost ghost mentioned this pull request Sep 14, 2022
Closed
@ghost
Copy link

ghost commented Sep 14, 2022 •
edited by ghost
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.812% (17472/19454) 👎 -0.003
Conditionals 77.144% (3193/4139) 👍 0.011
@basepi
Copy link
Contributor

basepi commented Sep 14, 2022

The tests will succeed once #1631 is merged. In the meantime, can you please sign the CLA when you get a chance? Your commits are signed with mail@franek.fr for reference.
@francoisfreitag
Copy link
Contributor Author

francoisfreitag commented Sep 15, 2022 •
edited
Loading

Thanks for the feedback! I believe the CLA is signed, DocuSign says it’ll be emailed to me when all participants have signed.
@basepi basepi enabled auto-merge (squash) September 15, 2022 13:58
@basepi basepi merged commit 77c2c0d into elastic:main Sep 15, 2022
@francoisfreitag francoisfreitag deleted the disable-checks branch September 15, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

2 participants

@francoisfreitag @basepi