GRPC Instrumentation #1703
Merged
GRPC Instrumentation #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
basepi reviewed Dec 5, 2022
Contributor
basepi left a comment
basepi left a comment There was a problem hiding this comment.
A few nits and questions, but looks excellent overall!
docs/grpc.asciidoc Outdated
| | ||
| | ||
| Once you have configured the agent, it will automatically track transactions | ||
| and capture uncaught exceptions within sanic. |
| args[2] = interceptors | ||
| else: | ||
| kwargs["interceptors"] = interceptors | ||
| return wrapper(*args, **kwargs) |
Contributor
There was a problem hiding this comment.
Is this a typo? Usually we use wrapped not wrapper, right?
Closed
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
This was referenced Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Instrument GRPC using interceptors. We use our instrumentation to insert our server and client interceptors, the interceptors take care of creating transactions and spans.
Testing is somewhat... interesting. We spawn a subprocess that runs the GRPC server, giving it the URL to our fake APM Server that runs in a thread of the main process. The GRPC client runs in the main thread. This allows for a full end-to-end test and introspection of all events (spans, transactions) from both the client and server.
Related issues
Closes #645