Fix race condition with extra metadata + partial transaction extra span #1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
basepi changed the title 
trentm previously approved these changes Oct 4, 2023
Member
trentm left a comment
trentm left a comment There was a problem hiding this comment.
I'll trust you on the .pause_sampling. I don't know the Python agent code well enough to grok that.
basepi force-pushed the lambda_metadata branch from eddbbfd to e567b97 Compare 
lahsivjar approved these changes Oct 5, 2023
lahsivjar left a comment
lahsivjar left a comment There was a problem hiding this comment.
Tested with the branch and didn't see any errors.
trentm approved these changes Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Eliminates the
add_metadatainteraction with the transport thread. We now generate our own metadata for sending the partial transaction, and also save the extra metadata in theClientobject so that it makes it into every future metadata build.Also, fixed the extra span being recorded when we send the partial transaction. Fixes #1902