Fix asyncpg tests to make it compatible with asyncpg>=0.29 #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 💚 CLA has been signed |
github-actions bot added agent-python community 
iurisilvio force-pushed the fix-1933-asyncpg branch 3 times, most recently from 73acc0e to e06940d Compare iurisilvio force-pushed the fix-1933-asyncpg branch from e06940d to 5a01d55 Compare 
basepi requested changes Nov 27, 2023
basepi approved these changes Nov 27, 2023
trentm approved these changes Nov 27, 2023
Contributor
| @elasticmachine, run elasticsearch-ci/docs |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
In asyncpg>=0.29, the query is passed as
kwargs["state"]instead of asargs.MagicStack/asyncpg@cbf64e1
I'm not sure if all cases are tested, maybe there are untested cases to fix?
Related issues
Closes #1933