Skip to content

Conversation

@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented May 19, 2021

Adding a description to address #787

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • I'm not a dev, so please check I'm not breaking anything 🤞

Related issues

Adding a description to address #787
@mostlyjason mostlyjason added enhancement New feature or request Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] labels May 19, 2021
@mostlyjason mostlyjason requested review from ruflin and urso May 19, 2021 10:37
@ruflin
Copy link
Contributor

ruflin commented May 19, 2021

You need to bump the version number in the manifest.yml and add a changelog entry to the changelog file so it gets released automatically aftewards to snapshot.

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM as soon as changelog and version number is increased.


To add this integration to an Elastic Agent, just add it to an agent policy. The Elastic Agents enrolled into that policy must run with additional credentials such as a service token. Learn how to add a Fleet Server our [documentation](https://www.elastic.co/guide/en/fleet/current/fleet-server.html).

## Compatibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this in the future to mention more precise how the compatiblity is? fleet-server needs to newer or equal Elastic Agents and the same with ES?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean Elastic Agent version must match Elasticsearch version??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ph I think the Elasticsearch version is addressed by the sentence "Fleet Server is compatible with the Elastic Stack and Elastic Agents version 7.13 or higher"

@elasticmachine
Copy link

elasticmachine commented May 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1008 updated

  • Start Time: 2021-05-19T11:19:54.414+0000

  • Duration: 10 min 13 sec

  • Commit: ac54177

Trends 🧪

Image of Build Times

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mostlyjason LGMT added a small notes about compatibility, but the text looks good to me and the version bump is also OK.

@mostlyjason mostlyjason merged commit 79330d1 into master May 19, 2021
@mostlyjason mostlyjason deleted the mostlyjason-patch-1 branch May 19, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent]

6 participants