Skip to content

[AWS] [ALB] Add ALB traffic on ELB log dashboard #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 18, 2024
Merged

[AWS] [ALB] Add ALB traffic on ELB log dashboard #10488

merged 8 commits into from
Jul 18, 2024

Conversation

@anil-elastic
Copy link
Contributor

@anil-elastic anil-elastic commented Jul 13, 2024 •
edited
Loading

Proposed commit message

Add Inbound and Outbound Traffic data for ALB on ELB log dashboard. ALB logs to populate http.request.body.bytes and http.response.body.bytes fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot_2024-07-12_12-19-23

Removed square brackets around ALB ( review comment)
filebeat-aws-elb-overview
@anil-elastic anil-elastic requested review from a team as code owners July 13, 2024 10:20
@elasticmachine
Copy link

elasticmachine commented Jul 13, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@anil-elastic anil-elastic requested review from agithomas and gpop63 July 13, 2024 12:55
@agithomas
Copy link
Contributor

agithomas commented Jul 14, 2024

Please remove the square brackets around ALB
@anil-elastic
Copy link
Contributor Author

anil-elastic commented Jul 15, 2024

Please remove the square brackets around ALB
@agithomas Updated the panel. Please review.
@agithomas
Copy link
Contributor

agithomas commented Jul 15, 2024

You may have to update the dashboard screenshot file - img/filebeat-aws-elb-overview.png
agithomas
agithomas reviewed Jul 15, 2024
View reviewed changes
agithomas
agithomas reviewed Jul 15, 2024
View reviewed changes
agithomas
agithomas reviewed Jul 15, 2024
View reviewed changes
@anil-elastic @agithomas
Update packages/aws/changelog.yml
3d86dc1 
Co-authored-by: Agi K Thomas <101976829+agithomas@users.noreply.github.com>
mbondyra
mbondyra approved these changes Jul 16, 2024
View reviewed changes
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🆗
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jul 17, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Jul 17, 2024

💚 Build Succeeded

History
agithomas
agithomas approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@anil-elastic anil-elastic merged commit 393f9af into elastic:main Jul 18, 2024
@elasticmachine
Copy link

elasticmachine commented Jul 18, 2024

Package aws - 2.19.0 containing this change is available at https://epr.elastic.co/search?package=aws
@anil-elastic anil-elastic deleted the integration-10149 branch August 16, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS

6 participants

@anil-elastic @elasticmachine @agithomas @mbondyra @gpop63 @andrewkroh